Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BSG***InsertIfNotNil #926

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Remove BSG***InsertIfNotNil #926

merged 1 commit into from
Dec 7, 2020

Conversation

nickdowell
Copy link
Contributor

Goal

These function do not add any safety, are not useful, and detract from readability.

Changeset

BSGArrayInsertIfNotNil and BSGDictInsertIfNotNil have been removed.

All uses have been replaced with direct insertion into dictionaries / arrays.

Testing

Ran the unit tests locally.

@nickdowell nickdowell merged commit a7407ad into next Dec 7, 2020
@nickdowell nickdowell deleted the nickdowell/remove-insert-if-not-nil branch December 7, 2020 08:13
@nickdowell nickdowell mentioned this pull request Dec 7, 2020
Closed
@kstenerud kstenerud mentioned this pull request Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattrali kattrali kattrali approved these changes

@kstenerud kstenerud Awaiting requested review from kstenerud kstenerud is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdowell @kattrali